From be02346ab2756c58f33da9fa8f8899993a7763dc Mon Sep 17 00:00:00 2001 From: Matthew Glenn Date: Mon, 10 Jun 2024 11:07:29 -0400 Subject: [PATCH] Fix PR Pipeline and Update github actions versions (#670) * Update deprecated actions calls * checkout with lfs * Run a clean install * use a regular npm install * include python install * Fix deprecated setup-python and upload-artifact calls * Upload mac build as an artifact in pr * Update upload artifact action (#2) --- .github/workflows/discord_release_hook.yml | 6 +++--- .github/workflows/main.yml | 12 ++++++------ .github/workflows/pullrequests.yml | 21 +++++++++++++++++---- 3 files changed, 26 insertions(+), 13 deletions(-) diff --git a/.github/workflows/discord_release_hook.yml b/.github/workflows/discord_release_hook.yml index ab58c1e8d6..5cebdbcb93 100644 --- a/.github/workflows/discord_release_hook.yml +++ b/.github/workflows/discord_release_hook.yml @@ -9,12 +9,12 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4.1.6 - name: Setup Node.js environment - uses: actions/setup-node@v2.4.1 + uses: actions/setup-node@v4.0.2 with: - node-version: 14.18.1 + node-version: 22.2.0 check-latest: true - name: Execute Discord webhook script diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index c0540fe08f..162e11a7e5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -17,15 +17,15 @@ jobs: os: [ubuntu-latest, windows-latest, macOS-latest] steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 + - uses: actions/checkout@v4.1.6 - name: Setup Python environment - uses: actions/setup-python@v4 + uses: actions/setup-python@v5.1.0 with: python-version: '3.10' - name: Setup Node.js environment - uses: actions/setup-node@v3 + uses: actions/setup-node@v4.0.2 with: node-version: 22.2.0 check-latest: true @@ -59,7 +59,7 @@ jobs: env: GH_TOKEN: ${{ secrets.DEPLOY_TOKEN }} - name: Upload Artifacts Windows - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4.3.3 if: ${{ matrix.os == 'windows-latest' }} with: name: srm-build-windows @@ -67,13 +67,13 @@ jobs: release/*.exe release/*.msi - name: Upload Artifacts Mac - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4.3.3 if: ${{ matrix.os == 'macOS-latest' }} with: name: srm-build-mac path: release/*.dmg - name: Upload Artifacts Linux - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4.3.3 if: ${{ matrix.os == 'ubuntu-latest' }} with: name: srm-build-linux diff --git a/.github/workflows/pullrequests.yml b/.github/workflows/pullrequests.yml index e400fcc7c5..90a6465dc9 100644 --- a/.github/workflows/pullrequests.yml +++ b/.github/workflows/pullrequests.yml @@ -19,10 +19,15 @@ jobs: os: [ubuntu-latest, windows-latest, macOS-latest] steps: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - - uses: actions/checkout@v3 + - uses: actions/checkout@v4.1.6 + + - name: Setup Python environment + uses: actions/setup-python@v5.1.0 + with: + python-version: '3.10' - name: Setup Node.js environment - uses: actions/setup-node@v3 + uses: actions/setup-node@v4.0.2 with: node-version: 22.2.0 check-latest: true @@ -51,7 +56,7 @@ jobs: run: npm run build:mac -- --publish=never - name: Upload Artifacts Windows - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4.3.3 if: ${{ matrix.os == 'windows-latest' }} with: name: srm-build-windows @@ -59,10 +64,18 @@ jobs: release/*.exe release/*.msi - name: Upload Artifacts Linux - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4.3.3 if: ${{ matrix.os == 'ubuntu-latest' }} with: name: srm-build-linux path: | release/*.deb release/*.AppImage + - name: Upload Artifacts Mac + uses: actions/upload-artifact@v4.3.3 + if: ${{ matrix.os == 'macOS-latest' }} + with: + name: srm-build-mac + path: | + release/*.dmg + release/*.zip \ No newline at end of file