New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break duplicated code into a function #6

Open

motiwari opened this issue Aug 5, 2022 · 0 comments

motiwari commented Aug 5, 2022

Duplicated code is dangerous for a lot of the same reasons magic numbers are (see #5): if something has to be changed, all sites have to be changed.

Instead, this code can be broken into functions which take the relevant parameters.

[Example][https://github.com/d1ngn1gefe1/momatools/blob/main/preproc/taxonomy_parser.py#L16-L56) just differs in filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment