Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The test app cannot be run #76

Closed
1 task done
luionTW opened this issue Nov 20, 2024 · 6 comments
Closed
1 task done

The test app cannot be run #76

luionTW opened this issue Nov 20, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@luionTW
Copy link

luionTW commented Nov 20, 2024

Description

/Users/xxxxxxxx/Library/Developer/Xcode/DerivedData/UITests-brggdwcrjsospgbzlyoajdgmympf/SourcePackages/checkouts/SpeziViews/Sources/SpeziViews/Views/Layout/HorizontalGeometryReader.swift:42:22 Main actor-isolated property 'width' can not be mutated from a Sendable closure

Please fix the bug for from SpeziViews repo.

Reproduction

Just tap Xcode build

Expected behavior

no error found during the build.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@luionTW luionTW added the bug Something isn't working label Nov 20, 2024
@PSchmiedmayer
Copy link
Member

Hi @luionTW, our current builds all seem to pass on the GitHub Action runners. Can you check which Xcode version and macOS version you are using? Please ensure that you use the latest versions. Our CI should catch any build errors but there might be configurations that we are missing and might need to add based on your feedback.

If it is an underlying bug in SpeziViews, can you try to replicate it in the other repository while also ensuring that you are using the latest Xcode version? Feel free to move the issue to SpeziViews if it is more applicable there.

@luionTW
Copy link
Author

luionTW commented Nov 21, 2024

Hi @PSchmiedmayer ,

Thanks the information.

I noticed that the Xcode version in GitHub Actions is 16.0.1, while I am using Xcode 16.2 beta and an iPhone 15 Pro. I am not sure if this is the root cause.

@PSchmiedmayer
Copy link
Member

Thank you for the additional context; it might be that the Xcode 16.2 beta could have changed some Swift behavior; can you try to reproduce the error in Spezi Views and see if there is a quick fix for the underlying issue?

Happy to see a PR that fixes this in time for Xcode 16.2 to be released 👍

@luionTW
Copy link
Author

luionTW commented Nov 27, 2024

Hi @PSchmiedmayer,

Here are the steps to reproduce the issue in the SpeziView repo:

  • Open the Tests project in Xcode 16.2 beta and compile it.
  • The error will be triggered immediately.

I am working on a fix, but it causes multiple dependency errors. Thank you.

Capture of 'state' with non-sendable type 'ValidationState.Binding' in a @Sendable closure

image

@bryan1anderson
Copy link

Can confirm this is a problem in Xcode 16.2. Swift 6 concurrency issues with non sendables crossing actor boundaries in several places

@philippzagar
Copy link
Member

philippzagar commented Dec 13, 2024

@bryan1anderson @luionTW Closing out the issue as a fix was merged in StanfordSpezi/SpeziViews#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants