From 7e31453c06f76ab3f2d0e7d3cff2e186d562dfd3 Mon Sep 17 00:00:00 2001 From: Andi Date: Wed, 20 Sep 2023 21:52:17 +0200 Subject: [PATCH] Upgrade tests to updated SpeziAccount (#16) # Upgrade tests to updated SpeziAccount ## :recycle: Current situation & Problem With https://github.com/StanfordSpezi/SpeziAccount/pull/23, SpeziAccount was updated to no longer automatically place itself into `NavigationStack`s and changed how the `SignupForm` is presented. This PR fixes compatibility in tests. ## :gear: Release Notes * Fixe UITests compatibility with latest SpeziAccount release. ## :books: Documentation Not affected. ## :white_check_mark: Testing Tests were adjusted. ## :pencil: Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md). --- Package.swift | 2 +- Tests/UITests/TestAppUITests/FirebaseAccountTests.swift | 4 ++-- Tests/UITests/UITests.xcodeproj/project.pbxproj | 2 +- .../project.xcworkspace/xcshareddata/swiftpm/Package.resolved | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Package.swift b/Package.swift index 8f47725..75482d0 100644 --- a/Package.swift +++ b/Package.swift @@ -24,7 +24,7 @@ let package = Package( ], dependencies: [ .package(url: "https://github.com/StanfordSpezi/Spezi", .upToNextMinor(from: "0.7.0")), - .package(url: "https://github.com/StanfordSpezi/SpeziAccount", .upToNextMinor(from: "0.5.0")), + .package(url: "https://github.com/StanfordSpezi/SpeziAccount", .upToNextMinor(from: "0.5.1")), .package(url: "https://github.com/StanfordSpezi/SpeziStorage", .upToNextMinor(from: "0.4.2")), .package(url: "https://github.com/firebase/firebase-ios-sdk", from: "10.13.0") ], diff --git a/Tests/UITests/TestAppUITests/FirebaseAccountTests.swift b/Tests/UITests/TestAppUITests/FirebaseAccountTests.swift index 0fc374d..5f11959 100644 --- a/Tests/UITests/TestAppUITests/FirebaseAccountTests.swift +++ b/Tests/UITests/TestAppUITests/FirebaseAccountTests.swift @@ -392,10 +392,10 @@ extension XCUIApplication { XCTAssertTrue(staticTexts["Please fill out the details below to create a new account."].waitForExistence(timeout: 6.0)) sleep(2) - try textFields["E-Mail Address"].enter(value: username) + try collectionViews.textFields["E-Mail Address"].enter(value: username) extendedDismissKeyboard() - try secureTextFields["Password"].enter(value: password) + try collectionViews.secureTextFields["Password"].enter(value: password) extendedDismissKeyboard() swipeUp() diff --git a/Tests/UITests/UITests.xcodeproj/project.pbxproj b/Tests/UITests/UITests.xcodeproj/project.pbxproj index 8d0885e..668c344 100644 --- a/Tests/UITests/UITests.xcodeproj/project.pbxproj +++ b/Tests/UITests/UITests.xcodeproj/project.pbxproj @@ -570,7 +570,7 @@ repositoryURL = "https://github.com/StanfordSpezi/SpeziAccount.git"; requirement = { kind = upToNextMinorVersion; - minimumVersion = 0.5.0; + minimumVersion = 0.5.1; }; }; 2F2E8EFD29E7369B00D439B7 /* XCRemoteSwiftPackageReference "SpeziViews" */ = { diff --git a/Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index 78c278b..29059bf 100644 --- a/Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/Tests/UITests/UITests.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -113,8 +113,8 @@ "kind" : "remoteSourceControl", "location" : "https://github.com/StanfordSpezi/SpeziAccount.git", "state" : { - "revision" : "040aec4d6cf60c2a0f566dbef6f357dc74847507", - "version" : "0.5.0" + "revision" : "1685d1c01a94f61ca6039df6cd22a94632ccab6d", + "version" : "0.5.1" } }, {