Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Indicator for Input-Related Messages #118

Open
1 task done
PSchmiedmayer opened this issue Dec 8, 2024 · 2 comments
Open
1 task done

Progress Indicator for Input-Related Messages #118

PSchmiedmayer opened this issue Dec 8, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@PSchmiedmayer
Copy link
Member

Problem

The dismissing of messages related to health measurements and questionnaire responses is dependent on cloud functions that might take a few seconds to complete. Until then, the messages on the Home Screen are not dismissed but also don't show any indication that calculations are happening in the background.

Solution

Add some custom logic around the messages related to questionnaires & health measurements and display a progress indicator for about 1 minute after new values have been submitted.

Additional context

The implementation could be very simple, using a variable in the relevant messages manager that stores the last recorded health measurement & questionnaire. If the date is less than a minute away we show a progress indicator on the relevant messages & possible a small message indicating that the measurements are processed.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@PSchmiedmayer PSchmiedmayer added enhancement New feature or request good first issue Good for newcomers labels Dec 8, 2024
@PaulGoldschmidt
Copy link

I'll take a look into this issue by tuesday and let you know any updates asap.

@PaulGoldschmidt
Copy link

I took a look at this issue - I'd propose to introduce a new processing state to track submitted measurements and questionnaire responses, implement a simple one-minute display, and extend our Messages implementation to show a nice loading indicator. This solution aligns well with the design pattern using the nice capsulestyle elements we already have in MessageRow, and also integrates well with our existing NotificationManager for handling edge cases.

As I see right now it, the changes would have effects on three areas: extending Message model for processing state tracking, showing a loading UI in MessageRow, and adding proper progress states to our submission functions like addMeasurement and questionnaire responses.

Any comments on this approach or should I start building @PSchmiedmayer and we take a look at the result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants