Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xgrid.py #1

Open
angeris opened this issue Nov 21, 2017 · 1 comment
Open

Fix xgrid.py #1

angeris opened this issue Nov 21, 2017 · 1 comment
Labels
enhancement

Comments

@angeris
Copy link
Contributor

angeris commented Nov 21, 2017

with_positions is unclear if it works as intended. Additionally, it would be good to replace the longer generator expressions with simple functional versions using itertools.
@ischeinfeld
Copy link
Contributor

I simplified with_positions a lot. It does the same thing but is much clearer now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angeris @ischeinfeld