Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with multishell #36

Open
RGFTheCoder opened this issue Jan 25, 2021 · 4 comments
Open

Issues with multishell #36

RGFTheCoder opened this issue Jan 25, 2021 · 4 comments

Comments

@RGFTheCoder
Copy link

MBS works when opening a multishell, but breaks if the tabs go away. Opening bg help and then closing help by tapping a key sets the input out of bounds. A sleep(4) program causes the input to be in the MOTD.
image
@Lupus590
Copy link
Contributor

Lupus590 commented Apr 20, 2021 •
edited
Loading

Screenshot (40)
Also, when closing the tab. But was fine if I opened a second tab and closed both (leaving just the original shell).

Tested in Copy Cat, MBS installed a few days ago.

@erisdev
Copy link

erisdev commented Jul 30, 2021 •
edited
Loading

Quick fix for the crash. Just change that line to this:

    -- Update the delegate window.
    if delegate then delegate.reposition(1, 1, sizeX, sizeY) end

Haven't investigated the other issue yet.

@Lupus590 Lupus590 mentioned this issue Oct 3, 2021
Closed
SquidDev added a commit that referenced this issue Oct 3, 2021
@SquidDev
Fix a couple of term resizing bugs
c0dd468 
 - Resize the term before resuming the child coroutine.
 - Update the cursor threshold when also moving the y cursor. Ensures
   that we don't accidentally begin a private mode when using readline.

   I'm not convinced that moving the y cursor is 100% sensible, but it
   seems to be /mostly/ fine.
 - Resize the delegate window with the new size, not the old one!

Fixes most of the issues in #36.
@hugeblank
Copy link

Another issue I've found related to multishell: you cannot use fg or bg in any directory besides /. The new tab crashes with a "No such program" error

SquidDev added a commit that referenced this issue Jan 2, 2023
@SquidDev
Use absolute paths in the shell launcher
0854cb6 
Fixes "No such program" errors as mentioned in #36
@SquidDev
Copy link
Member

SquidDev commented Jan 2, 2023

Ahh, that one was an easy fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@erisdev @SquidDev @Lupus590 @hugeblank @RGFTheCoder