-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust replace_origin
#38
Comments
Thanks for opening this issue! The long-term solution to this is that we'll be adding the ability to run on-demand tests against any URL. It might be some time before this is implemented, so I'll have a think about potential short-term solutions and get back to you. |
Has there been any change wrt this caveat? It looks like the action still works this way |
Hey @jasikpark! We have some ideas around how to improve this, but our engineering effort has been focused elsewhere. We are aiming to pick up a big CI/CD project soon, and one of our primary goals is to seamlessly support a PR-based workflow. |
awesome! it's been great to see improvements per diff after setting up this action, but I'm sure it'll be better once we can ensure that we can separate deploys on |
We generate PR previews for each commit to a PR and generally have ~25-40 PRs open. Using
replace_origin
which temporarily updates the URLs is therefore not really a workable strategy for us, as PRs might interfere.The text was updated successfully, but these errors were encountered: