Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athenizer deflater doesn't use project configuration #1534

Open
yuvalsimon opened this issue Jun 22, 2017 · 5 comments
Open

Athenizer deflater doesn't use project configuration #1534

yuvalsimon opened this issue Jun 22, 2017 · 5 comments
Assignees
Labels
Milestone

Comments

@yuvalsimon
Copy link
Collaborator

When spartanizing using SingleFlater (mouse wheel) all the tippers are enabled and not only those as configured.
Should it be this way?

@yuvalsimon yuvalsimon added the bug label Jun 22, 2017
@yuvalsimon yuvalsimon added this to the Week 13 - Last Week milestone Jun 22, 2017
@OriRoth OriRoth changed the title Athenizer shortcuts don't use spartanizer conf Athenizer deflater doesn't use project configuration Jun 22, 2017
@OriRoth
Copy link
Collaborator

OriRoth commented Jun 22, 2017

The solution should be disabling tipper-bloater couples using the spartanizer configuration---if a tipper is disabled so should be its contra bloater, and vise versa. Lonely bloaters require separate configuration, but this is stage 2.

@ravivos
Copy link
Collaborator

ravivos commented Jun 28, 2017

It's not a bug, it's a feature.
Meaning when using the athenizer we want to zoom in and zoom out, regardless of the spartanizer preferences which is not related to this plugin

@ravivos ravivos closed this as completed Jun 28, 2017
@OriRoth
Copy link
Collaborator

OriRoth commented Jun 29, 2017

IT MAY BE A FEATURE, BUT NOT A GOOD ONE. Please regard my comment about the subject.

@OriRoth OriRoth reopened this Jun 29, 2017
@OriRoth
Copy link
Collaborator

OriRoth commented Jun 29, 2017

You can remove the milestone assignment if you want, but do not close the issue.

@ravivos
Copy link
Collaborator

ravivos commented Jun 29, 2017

But the athenizer shouldn't use the spartanizer preferences at all!
it doesn't make sense that it will, thus the following use-case:
A programmer from Brauda college doesn't want to use any of the spartanizer tips, but does want to use the athenizer wheel feature so he expands his code using the mouse wheel.
now when he finishes, he would like to get back to the less expanded version therefore he will zoom out but if the spartanizer prefs would be related to the athenizer then nothing would happen.
So we Do prefer it the way it is right now.
Therefore, closing this issue

@ravivos ravivos closed this as completed Jun 29, 2017
@OriRoth OriRoth reopened this Jun 29, 2017
@ravivos ravivos added wontfix and removed wontfix labels Jun 29, 2017
@ravivos ravivos modified the milestones: Week 13 - Last Week, backlog Jun 29, 2017
@ravivos ravivos removed their assignment Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants