Personalized Communication History Times Out

[azturner]

Description

Reported on behalf of Coastal Community Church

The Personalized Communication History block is consistently timing out for one particular person in Coastal's database. This person has 204 person alias records and is a recipient on about 504 communication records.

After debugging this issue, determined it is the GetCommunicationListItems method in the PersonalizedCommunicationHistory block. After changing this code:

var qryListItems = qryCommunicationRecipients
	.OrderByDescending( c => c.Communication.CreatedDateTime )
	.AsNoTracking()
	.Select( ciGroup =>
		new CommunicationListItem
		{
			RowId = "C" + ciGroup.Communication.Id + "R" + ciGroup.Recipient.Id,
			Id = ciGroup.Communication.Id,
			CommunicationType = ciGroup.Communication.CommunicationType,
			CommunicationStatus = ciGroup.Communication.Status,
			Title = ciGroup.Communication.CommunicationType == CommunicationType.Email ? ciGroup.Communication.Subject
				: ciGroup.Communication.CommunicationType == CommunicationType.SMS ? ciGroup.Communication.Name
				: ciGroup.Communication.CommunicationType == CommunicationType.PushNotification ? ciGroup.Communication.PushTitle
				: ciGroup.Communication.Name,
			CreatedDateTime = ciGroup.Communication.CreatedDateTime,
			SendDateTime = ciGroup.Communication.SendDateTime ?? ciGroup.Communication.FutureSendDateTime ?? ciGroup.Communication.CreatedDateTime,
			Sender = ciGroup.Communication.SenderPersonAlias != null ? ciGroup.Communication.SenderPersonAlias.Person : null,
			RecipientStatus = ciGroup.Recipient.Status,
			RecipientStatusNote = ciGroup.Recipient.StatusNote,
			CreatedByPersonAliasId = ciGroup.Communication.CreatedByPersonAliasId,
			RecipientTotal = ciGroup.Communication.Recipients.Count,
			InternalCommunicationMediumId = ciGroup.Recipient.MediumEntityTypeId
		} );

var items = qryListItems.ToList();

To This:

var listItems = qryCommunicationRecipients
	.AsNoTracking()
	.ToList();

var items = listItems
	.Select( ciGroup =>
		new CommunicationListItem
		{
			RowId = "C" + ciGroup.Communication.Id + "R" + ciGroup.Recipient.Id,
			Id = ciGroup.Communication.Id,
			CommunicationType = ciGroup.Communication.CommunicationType,
			CommunicationStatus = ciGroup.Communication.Status,
			Title = ciGroup.Communication.CommunicationType == CommunicationType.Email ? ciGroup.Communication.Subject
				: ciGroup.Communication.CommunicationType == CommunicationType.SMS ? ciGroup.Communication.Name
				: ciGroup.Communication.CommunicationType == CommunicationType.PushNotification ? ciGroup.Communication.PushTitle
				: ciGroup.Communication.Name,
			CreatedDateTime = ciGroup.Communication.CreatedDateTime,
			SendDateTime = ciGroup.Communication.SendDateTime ?? ciGroup.Communication.FutureSendDateTime ?? ciGroup.Communication.CreatedDateTime,
			Sender = ciGroup.Communication.SenderPersonAlias != null ? ciGroup.Communication.SenderPersonAlias.Person : null,
			RecipientStatus = ciGroup.Recipient.Status,
			RecipientStatusNote = ciGroup.Recipient.StatusNote,
			CreatedByPersonAliasId = ciGroup.Communication.CreatedByPersonAliasId,
			RecipientTotal = ciGroup.Communication.Recipients.Count,
			InternalCommunicationMediumId = ciGroup.Recipient.MediumEntityTypeId
		} )
	.OrderByDescending( c => c.CreatedDateTime )
	.ToList();

The block started working correctly and results were displayed in just a few seconds.

Actual Behavior

Page gets a timeout error

Expected Behavior

Page should not get a timeout error

Steps to Reproduce

Couldn't reproduce on test or new database.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

v16.6

Client Culture Setting

en-US