Completed Workflows Connected to Connection Request Deletion Issues

[dataCollegechurch]

Description

Completed workflows Connected launched from a connection request present two issues.

1. They are not automatically cleaned up by the Rock cleanup job after its days completed exceeds the Completed Workflow Retention Period (days)
2. When you attempt to manually delete them, you are presented with a warning "This Workflow is assigned to a Connection Request Workflow."

Actual Behavior

Completed workflows Connected launched from a connection request present two issues.

1. They are not automatically cleaned up by the Rock cleanup job after its days completed exceeds the Completed Workflow Retention Period (days)
   
   

2. When you attempt to manually delete them, you are presented with a warning "This Workflow is assigned to a Connection Request Workflow."
   

Expected Behavior

A completed workflow regardless of what it is connected to would be deleted after its days completed exceeds the Completed Workflow Retention Period (days). A user can delete a completed workflow that is assigned to a Connection Request Workflow.

Steps to Reproduce

1. Upload this workflow
   Notify Connector of Future Follow-Up Date Reached_202412300943.json
2. Setup the workflow to launch when a future follow-up date is reached
   
3. Set the connector and future follow-up date to today on an active connection request
   
4. Run the Connection Request Workflow Triggers, this will generate a workflow tied to a connection request
   
5. Attempt to delete completed workflow
6. After the days completed exceeds the Completed Workflow Retention Period (days), run the rock clean up job
   
7. See that the completed workflow remains
   

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Reproduced the problem on a fresh install or on the demo site.

Rock Version

16.7

Client Culture Setting

en-US

[JimMichael]

I agree that this is odd behavior, particularly because there is a "Delete" button at the bottom of the Workflow Instance grid

that DOES delete these Connection-Request-Initiated workflows when they are selected and the button is pressed:

This implies that it's possible/ok to delete such workflows, but the other deletion methods (manully clicking x and cleanup job) just don't work the same way.