[EN] Change Slingshot to handle multiple updates of person data

[JoshuaMaiorino]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Can you reproduce the problem on a fresh install or the demo site ?
  • Did you include your Rock version number and client culture setting?
  • Did you %3Aissue+user%3ASparkDevNetwork+-repo%3ASparkDevNetwork%2FSlack perform a cursory search to see if your bug or enhancement is already reported?

Description

There's a bug in the Update portion of slingshot. If after doing an initial import, A person's family is changed in the legacy system, and then an update is attempted, and there's an address within that family it will throw an Insert error when trying to add the new address.

This bug is reported in the slingshot repot here, however the code is in Rock. SparkDevNetwork/Slingshot#3

Steps to Reproduce

1. Import data from a legacy system
2. Move an individual from there current family and add them to a new family with an address in the legacy system
3. Import with Update again

Expected behavior:

The import should add the new family prior to updating the person record.

Actual behavior:

Slingshot attempts to update the person, and add the new address to a family that hasn't been inserted yet, and thus throws an insert error.

Versions

• Rock Version: [7+]
• Client Culture Setting: [EN-US]

[JoshuaMaiorino]

                    if ( this.ImportUpdateOption == ImportUpdateType.AlwaysUpdate )
                    {
                        Stopwatch stopwatchPersonUpdates = Stopwatch.StartNew();
                        bool wasChanged = UpdatePersonFromPersonImport( person, personImport, attributeValuesLookup, familiesLookup, foreignSystemKey, importDateTime );
                        stopwatchPersonUpdates.Stop();
                        personUpdatesMS += stopwatchPersonUpdates.ElapsedMilliseconds;
                        if ( wasChanged )
                        {
                            personUpdatesCount++;
                        }
                    }

Instead of performing the actual update here, I wonder if it makes sense to store the people to update in a list, and then loop through them after the bulk inserts, which would add the families, prior to trying to add the locations. The family lookup would also have to be updated post inserting the new records. or just how the primary family is gotten would have to be changed.

[nairdo]

I confirmed this today with the team and the original intent of Slingshot is a one time import of data -- it's not intended for continual syncing use. Having said that, it sounds like we may adjust Slingshot in the future to deal with second import attempts (for only a very limited set of data however). Slingshot is not intended to be used as a sync tool.

[jonedmiston]

We now have a new Ideas area on our Rock Community website (https://community.rockrms.com/ideas) for posting, discussing and voting on enhancements to Rock. Since this issue is tagged as an enhancement we are closing it and requesting that if you still feel it has merit that you add it as an idea. This allows the full community to speak into it and help us determine it's priority.