Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix - don't send empty string in faculty #71

Closed
chewmanji opened this issue Jan 4, 2025 · 0 comments · Fixed by #72
Closed

Fix - don't send empty string in faculty #71

chewmanji opened this issue Jan 4, 2025 · 0 comments · Fixed by #72
Assignees
@chewmanji
Labels
bug Something isn't working

Comments

@chewmanji
Copy link
Member

In current implementation when we send "" in faculty field in case the user didn't choose specific faculty, model starts to hallucinate and generates fakes data
@chewmanji chewmanji added the bug Something isn't working label Jan 4, 2025
@chewmanji chewmanji self-assigned this Jan 4, 2025
@chewmanji chewmanji linked a pull request Jan 4, 2025 that will close this issue
Send nothing when faculty is not specified #72
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chewmanji chewmanji

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send nothing when faculty is not specified Solvro/web-promochator
1 participant
@chewmanji