feat: add emails endpoints #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidlinek
requested changes
Jan 8, 2025
app/controllers/emails_controller.ts
Outdated
Comment on lines
13
to
25
| const emails = await Email.query() | ||
| .where('event_id', eventId) | ||
| .preload('participants', async (query) => { | ||
| await query.pivotColumns(['status']) | ||
| }) | ||
|
|
||
| const emailSummaries = emails.map((email) => ({ | ||
| id: email.id, | ||
| name: email.name, | ||
| pending: email.participants.filter((p) => p.$extras.pivot_status === 'pending').length, | ||
| sent: email.participants.filter((p) => p.$extras.pivot_status === 'sent').length, | ||
| failed: email.participants.filter((p) => p.$extras.pivot_status === 'failed').length, | ||
| })) |
There was a problem hiding this comment.
@kamilramocki spróbuj użyć withCount z custom query w którym podajesz status (albo może grupowanie tez zadziała?)
https://lucid.adonisjs.com/docs/model-query-builder#withcount
app/controllers/emails_controller.ts
Outdated
Comment on lines
38
to
52
| if (data.trigger) { | ||
| const validTriggers = ['participant_registered', 'form_filled', 'attribute_changed'] | ||
| if (!validTriggers.includes(data.trigger)) { | ||
| return response.status(400).send({ message: 'Invalid trigger provided.' }) | ||
| } | ||
|
|
||
| if ( | ||
| (data.trigger === 'form_filled' || data.trigger === 'attribute_changed') && | ||
| !data.triggerValue | ||
| ) { | ||
| return response | ||
| .status(400) | ||
| .send({ message: 'Trigger value is required for the selected trigger.' }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Przenieśmy to do walidatora
Może się przydać: https://vinejs.dev/docs/conditional_validation#requiredwhen
app/controllers/emails_controller.ts
Outdated
| * Create an email for a specific event | ||
| */ | ||
| async store({ params, request, response }: HttpContext) { | ||
| const eventId = Number(params.id) |
There was a problem hiding this comment.
Myślę, że mimo wszystko powinniśmy sprawdzić czy dany event istnieje i wtedy może utworzyć event.related('emails').create(data)
app/controllers/emails_controller.ts
Outdated
Comment on lines
85
to
99
| if (data.trigger) { | ||
| const validTriggers = ['participant_registered', 'form_filled', 'attribute_changed'] | ||
| if (!validTriggers.includes(data.trigger)) { | ||
| return response.status(400).send({ message: 'Invalid trigger provided.' }) | ||
| } | ||
|
|
||
| if ( | ||
| (data.trigger === 'form_filled' || data.trigger === 'attribute_changed') && | ||
| !data.triggerValue | ||
| ) { | ||
| return response | ||
| .status(400) | ||
| .send({ message: 'Trigger value is required for the selected trigger.' }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Tu może być ten sam walidator co wyżej
Comment on lines
58
to
83
| const participant = await Participant.findOrFail(params.id); | ||
|
|
||
| const emailId = request.input('email_id') as number; | ||
|
|
||
| const pivotData = request.only(['send_at', 'send_by', 'status']) as { | ||
| send_at?: string; | ||
| send_by?: string; | ||
| status?: string; | ||
| }; | ||
|
|
||
| await participant.related('emails').attach({ [emailId]: pivotData }); | ||
| return response.status(201).send({ message: 'Email successfully attached.' }); | ||
| } | ||
|
|
||
| /** | ||
| * Detach email from participant | ||
| */ | ||
| async detachEmail({ params, request, response }: HttpContext) { | ||
| const participant = await Participant.findOrFail(params.id); | ||
|
|
||
| const emailId = request.input('email_id') as number; | ||
|
|
||
| await participant.related('emails').detach([emailId]); | ||
| return response.status(200).send({ message: 'Email successfully detached.' }); | ||
| } |
There was a problem hiding this comment.
To rozwiążemy potem, bo nie będzie czegoś takiego jak detach email, będzie sendEmail i jak już zostanie wysłany to nie można go usunąć
dawidlinek
requested changes
Jan 20, 2025
There was a problem hiding this comment.
@kamilramocki już wygląda to dobrze. Jak zrobisz testy i dokumentację to będzie można mergować
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.