Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay when saving tracking error transforms #12

Open
lassoan opened this issue Aug 26, 2015 · 7 comments
Open

Delay when saving tracking error transforms #12

lassoan opened this issue Aug 26, 2015 · 7 comments

Comments

@lassoan
Copy link
Contributor

lassoan commented Aug 26, 2015

When loading a saved pos and orientation error .h5 TPS transform file, the transforms module shows that the number of landmarks is 0.

When a TPS transform is created by the Landmark registration module and we save and reload that, the saving works.

@vinyasHarish95
Copy link
Contributor

Using Slicer 4.5, it appears that the transforms are indeed saving properly (verified by checking the number of source and target landmarks) however they take a really really long time. Is there any way to speed it up? I tried saving while displaying the "warped grid" view & sampling points as well without displaying them, but did not notice an improvement.

@lassoan
Copy link
Contributor Author

lassoan commented May 18, 2016

How long does it take? How large the resulting file is?

@vinyasHarish95
Copy link
Contributor

About 2 or 3 minutes to save two 40 kB files (the position and orientation transforms). Since Slicer freezes while this is happening, we do not know if the save is actually working or the program is about to crash.

@lassoan
Copy link
Contributor Author

lassoan commented May 18, 2016

Can you send me those saved files in an email so that I can have a look?

@lassoan
Copy link
Contributor Author

lassoan commented May 18, 2016

I’ve fixed one source of delay in the Slicer core. The fix will be available in tomorrow’s nightly build. Writing speed can probably further improved by setting transform To parent instead of transform From parent when we initialize the transform (SetAndObserveTransformToParent). Let’s make this change after all the automatic tests are in place to make sure we don’t introduce any regressions.

@vinyasHarish95 vinyasHarish95 changed the title Tracking error transforms are not saved correctly Delay when saving tracking error transforms May 18, 2016
@vinyasHarish95
Copy link
Contributor

Sounds good Andras, I have updated the issue title to reflect this.

Why does changing 'from' to 'to' parent as outlined above result in a speed boost?

@lassoan
Copy link
Contributor Author

lassoan commented May 18, 2016

Always the FromParent transform is written to file. Inversion of a TPS transform with hundreds of input points takes some time (up to a few ten seconds).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants