Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R111: Target Size (1st version) #1552

Closed
rcj-siteimprove opened this issue Jan 17, 2024 · 0 comments · Fixed by #1564
Closed

Implement SIA-R111: Target Size (1st version) #1552

rcj-siteimprove opened this issue Jan 17, 2024 · 0 comments · Fixed by #1564
Assignees
@rcj-siteimprove
Labels
minor Backwards-compatible change that touches public API

Comments

@rcj-siteimprove
Copy link
Contributor

See act-rules/act-rules.github.io#1919

We should make a simple first version which probably will have many false negatives (but shouldn't have any false positives).

The ideas for the first version:

  • No z-index analysis to find correct shape, we just use bounding box
  • Ignore scrolling that will affect shape
@rcj-siteimprove rcj-siteimprove added the minor Backwards-compatible change that touches public API label Jan 17, 2024
@rcj-siteimprove rcj-siteimprove self-assigned this Jan 17, 2024
@rcj-siteimprove rcj-siteimprove changed the title Implement SIA-R111: Target Size Implement SIA-R111: Target Size (1st version) Jan 17, 2024
@rcj-siteimprove rcj-siteimprove mentioned this issue Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcj-siteimprove rcj-siteimprove

Labels
minor Backwards-compatible change that touches public API
Projects
⚙️ Alfa Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SIA-R111 (Target size) Siteimprove/alfa
1 participant
@rcj-siteimprove