-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Handle division by 0 #129
Comments
came across the same issue, thx for raising @mbpictures |
prince-d-simform
added a commit
that referenced
this issue
Nov 13, 2024
prince-d-simform
added a commit
that referenced
this issue
Nov 13, 2024
prince-d-simform
added a commit
that referenced
this issue
Nov 13, 2024
mukesh-simform
added a commit
that referenced
this issue
Nov 13, 2024
…sue-#129-Handle-division-by-0 fix(UNT-T30512): Issue #129 Handle division by 0
We have released a new version 2.1.2. Please use that, and if the issue still persists, reopen or create a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
When the container of the Waveform Component has no width, the noOfSamples passed to the native is 0, and then the app crashes due to division by 0 error. It would offer a much better DX when you catch this case by e.g. don't render anything, when the width is 0 anyways, give the container a minimum width or at least make a Math.Max(noOfSampels, 1), so the app doesn't crash.
The text was updated successfully, but these errors were encountered: