Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Better handling of current playing player or recorder #124

Closed
dprevost-LMI opened this issue Oct 20, 2024 · 1 comment · Fixed by #123
Closed

[FEATURE] Better handling of current playing player or recorder #124

dprevost-LMI opened this issue Oct 20, 2024 · 1 comment · Fixed by #123

Comments

@dprevost-LMI
Copy link
Contributor

dprevost-LMI commented Oct 20, 2024

As shown in the image below, in the current example app, the stop action is called for all the other players when stopping one player or starting another. This does not scale when there are hundreds of them. Also, with around 40 players, we see a noticeable lag when playing one audio after another.

image

By adding the playerState and the playerKey in this PR, I could review the logic in the example app so that we could only stop the previous player from playing instead of all of them.

Finally, by adding the recorderState, I also managed to stop any player when starting a recording.

@kuldip-simform kuldip-simform linked a pull request Oct 23, 2024 that will close this issue
@kuldip-simform
Copy link
Contributor

We have released a new version 2.1.2. Please use that, and if the issue still persists, reopen or create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants