feat: [Example App] keep recording on reboot + allow to delete them #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuldip-simform
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@dprevost-LMI I have added some comments. Can you please resolve them so we can approve this PR and merge this.
I like this very much. This improves user experience who are using our example app to try out this library.
Thank you so much for your efforts to improve this library.
kuldip-simform
requested changes
Oct 23, 2024
kuldip-simform
previously approved these changes
Oct 23, 2024
mukesh-simform
dismissed
kuldip-simform’s stale review
The base branch was changed.
Co-authored-by: kuldip-simform <[email protected]>
dprevost-LMI
force-pushed
the
show-recoring-on-boot-and-delete-recording
branch
from
a0510c0 to
c164249
Compare
|
Hey, I rebased and revalidated that we can see the icon on iOS! @kuldip-simform do you mind reapproving, 🙏 , I rebase from |
kuldip-simform
approved these changes
Nov 13, 2024
mukesh-simform
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRecordedAudiosthat fetchesm4aaudio files from the cache for Android or document for iOS.but an app reboot is required to see the effect!