From b41ce370e205e3b632c02d2761b9a58307fe5a9d Mon Sep 17 00:00:00 2001 From: prince_dobariya Date: Wed, 13 Nov 2024 14:51:12 +0530 Subject: [PATCH] fix(UNT-T30512): Issue #129 Handle division by 0 --- .../src/main/java/com/audiowaveform/AudioWaveformModule.kt | 4 ---- src/components/Waveform/Waveform.tsx | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/android/src/main/java/com/audiowaveform/AudioWaveformModule.kt b/android/src/main/java/com/audiowaveform/AudioWaveformModule.kt index cacd076..6565958 100644 --- a/android/src/main/java/com/audiowaveform/AudioWaveformModule.kt +++ b/android/src/main/java/com/audiowaveform/AudioWaveformModule.kt @@ -300,10 +300,6 @@ class AudioWaveformModule(context: ReactApplicationContext): ReactContextBaseJav promise.reject("createOrUpdateExtractor Error" , "No Path Provided") return } - if(noOfSamples < 1){ - promise.reject("createOrUpdateExtractor Error" , "No Enough Waves Sample Available") - return - } extractors[playerKey] = WaveformExtractor( context = reactApplicationContext, path = path, diff --git a/src/components/Waveform/Waveform.tsx b/src/components/Waveform/Waveform.tsx index d156df5..dcbf604 100644 --- a/src/components/Waveform/Waveform.tsx +++ b/src/components/Waveform/Waveform.tsx @@ -180,7 +180,7 @@ export const Waveform = forwardRef((props, ref) => { const result = await extractWaveformData({ path: path, playerKey: `PlayerFor${path}`, - noOfSamples: noOfSample, + noOfSamples: Math.max(noOfSample, 1), }); (onChangeWaveformLoadState as Function)?.(false);