feat: ✨ Add a method to pause all players at once #372

himanshuGandhiSimform · 2024-12-02T11:35:46Z

Fixed 325

CHANGELOG.md

ujas-m-simformsolutions · 2024-12-05T08:43:23Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioPlayer.kt

@@ -140,15 +140,16 @@ class AudioPlayer(
    }


-    fun pause(result: MethodChannel.Result) {
+    fun pause(result: MethodChannel.Result, isPauseAllPlayer: Boolean = false) {


Why do we need this boolean?

ujas-m-simformsolutions · 2024-12-05T08:43:45Z

ios/Classes/AudioPlayer.swift

@@ -91,10 +91,12 @@ class AudioPlayer: NSObject, AVAudioPlayerDelegate {
    }


-    func pausePlayer(result: @escaping FlutterResult) {
+    func pausePlayer(result: @escaping FlutterResult, isPauseAllPlayer: Bool = false) {


ios/Classes/SwiftAudioWaveformsPlugin.swift

lib/src/controllers/player_controller.dart

ujas-m-simformsolutions · 2024-12-09T07:22:09Z

README.md

+```dart
+playerController.pauseAllPlayers();
+```
+There could be any number of players but you can just call this function from any **one** player and it will pause all the players.


Just write, this function works similar to stopAllPlayer.

@jay-simformsolutions update to this this function works similar to stopAllPlayer but just pauses all players.

ujas-m-simformsolutions · 2025-01-07T11:01:43Z

example/lib/main.dart

Remove this changes

ujas-m-simformsolutions · 2025-01-07T11:01:57Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioPlayer.kt

+        stopListening()
+        player?.pause()


add try catch

ujas-m-simformsolutions · 2025-01-07T11:02:05Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioPlayer.kt

@@ -129,26 +129,19 @@ class AudioPlayer(
        }
    }

-    fun stop(result: MethodChannel.Result) {
+    fun stop() {
        stopListening()


add try catch

ujas-m-simformsolutions · 2025-01-07T11:09:46Z

lib/src/controllers/player_controller.dart

+          .forEach((playKey, controller) {
+        controller._setPlayerState(PlayerState.stopped);
+      });
+    }
    PlatformStreams.instance.playerControllerFactory.clear();


we dont need clear since we aren't releasing player.

ujas-m-simformsolutions · 2025-01-07T11:10:08Z

pubspec.yaml

@@ -1,6 +1,6 @@
 name: audio_waveforms
 description: A Flutter package that allow you to generate waveform while recording audio or from audio file.
-version: 1.2.0
+version: 1.2.1


update to 1.3.0

ujas-m-simformsolutions · 2025-01-09T08:47:01Z

CHANGELOG.md

@@ -3,6 +3,8 @@
 - Fixed [#386](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/386) - On permission denied isRecording flag changed
 - Fixed [#384](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/384) - Provide a callback of drag,tap,start and end details on user gesture
 - Fixed [#309](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/309) - Added support for Liner PCM codec in iOS
+- Fixes [#325](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/issues/325) - Added feature to pause all player controller at once.
+- Fixes [#379](https://github.com/SimformSolutionsPvtLtd/audio_waveforms/pull/379) - Getting error on dispose(Cannot add new events after calling close)


Use issue link.

ujas-m-simformsolutions · 2025-01-09T08:48:12Z

README.md

+```dart
+playerController.pauseAllPlayers();
+```
+There could be any number of players but you can just call this function from any **one** player and it will pause all the players.


@jay-simformsolutions update to this this function works similar to stopAllPlayer but just pauses all players.

ujas-m-simformsolutions · 2025-01-13T06:09:56Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt

@@ -102,7 +102,8 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
            Constants.stopPlayer -> {
                val key = call.argument(Constants.playerKey) as String?
                if (key != null) {
-                    audioPlayers[key]?.stop(result)
+                    audioPlayers[key]?.stop()


add try catch

ujas-m-simformsolutions · 2025-01-13T06:10:05Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt

@@ -111,7 +112,8 @@ class AudioWaveformsPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
            Constants.pausePlayer -> {
                val key = call.argument(Constants.playerKey) as String?
                if (key != null) {
-                    audioPlayers[key]?.pause(result)
+                    audioPlayers[key]?.pause()


add try catch

ujas-m-simformsolutions · 2025-01-13T06:10:41Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt

+            }
+            result.success(true)
+        } catch (e: Exception) {
+            result.error(Constants.LOG_TAG, "Failed to pause player", e.message)


Suggested change

result.error(Constants.LOG_TAG, "Failed to pause player", e.message)

result.error(Constants.LOG_TAG, "Failed to pause players", e.message)

ujas-m-simformsolutions · 2025-01-13T06:10:56Z

android/src/main/kotlin/com/simform/audio_waveforms/AudioWaveformsPlugin.kt

+            }
+            result.success(true)
+        } catch (e: Exception) {
+            result.error(Constants.LOG_TAG, "Failed to stop player", e.message)


Suggested change

result.error(Constants.LOG_TAG, "Failed to stop player", e.message)

result.error(Constants.LOG_TAG, "Failed to stop players", e.message)

ujas-m-simformsolutions · 2025-01-13T06:11:17Z

example/lib/chat_bubble.dart

@@ -152,7 +152,7 @@ class _WaveBubbleState extends State<WaveBubble> {
                    IconButton(
                      onPressed: () async {
                        controller.playerState.isPlaying
-                            ? await controller.pausePlayer()
+                            ? await controller.stopAllPlayers()


remove this change

ujas-m-simformsolutions · 2025-01-13T06:12:34Z

lib/src/controllers/player_controller.dart

@@ -318,10 +318,32 @@ class PlayerController extends ChangeNotifier {
  ///
  /// This method will close the stream and free resources taken by all
  /// players. This method will not dispose controller.
-  Future<void> stopAllPlayers() async {
+  ///
+  /// Returns true if all player stopped otherwise return false.


Check grammar

ujas-m-simformsolutions · 2025-01-13T06:14:01Z

lib/src/controllers/player_controller.dart

+    return isAllPlayersStopped;
+  }
+
+  /// This function works similar to stopAllPlayer.


Suggested change

/// This function works similar to stopAllPlayer.

/// Pauses all the players. Works similar to stopAllPlayer.

ujas-m-simformsolutions requested changes Dec 5, 2024

View reviewed changes

himanshuGandhiSimform force-pushed the feature/325/pause_all_players branch from 26deec9 to ef20485 Compare December 9, 2024 07:15

jay-simformsolutions force-pushed the feature/325/pause_all_players branch from ef20485 to ba326d8 Compare January 7, 2025 10:57

ujas-m-simformsolutions reviewed Jan 7, 2025

View reviewed changes

feat: ✨ Add a method to pause all players at once

e9850d7

jay-simformsolutions force-pushed the feature/325/pause_all_players branch from ba326d8 to e9850d7 Compare January 8, 2025 06:35

ujas-m-simformsolutions reviewed Jan 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ✨ Add a method to pause all players at once #372

feat: ✨ Add a method to pause all players at once #372

himanshuGandhiSimform commented Dec 2, 2024

ujas-m-simformsolutions Dec 5, 2024

ujas-m-simformsolutions Dec 5, 2024

ujas-m-simformsolutions Dec 9, 2024

ujas-m-simformsolutions Jan 9, 2025

ujas-m-simformsolutions Jan 7, 2025

ujas-m-simformsolutions Jan 7, 2025

ujas-m-simformsolutions Jan 7, 2025

ujas-m-simformsolutions Jan 7, 2025

ujas-m-simformsolutions Jan 7, 2025

ujas-m-simformsolutions Jan 9, 2025

ujas-m-simformsolutions Jan 9, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

ujas-m-simformsolutions Jan 13, 2025

	result.error(Constants.LOG_TAG, "Failed to pause player", e.message)
	result.error(Constants.LOG_TAG, "Failed to pause players", e.message)

	/// This function works similar to stopAllPlayer.
	/// Pauses all the players. Works similar to stopAllPlayer.

feat: ✨ Add a method to pause all players at once #372

Are you sure you want to change the base?

feat: ✨ Add a method to pause all players at once #372

Conversation

himanshuGandhiSimform commented Dec 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment