Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: Move playhead position with waveform gesture onTapDown #204

Open
p4-k4 opened this issue Mar 31, 2023 · 3 comments
Open

Implemented: Move playhead position with waveform gesture onTapDown #204

p4-k4 opened this issue Mar 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@p4-k4
Copy link

p4-k4 commented Mar 31, 2023

I've implemented it, but have no idea how to make PR's (or operate git). Could this be considered?

When enableSeekGesture is set as true, this will move the playhead position even when playback is paused or stopped. Currently only moves playhead position whilst in a playing state.

audio_file_waveform.dart L214

        onTapDown: (details) async {
          if (widget.enableSeekGesture) {
            final _maxDuration = await widget.playerController.getDuration();
            _audioProgress = details.localPosition.dx / widget.size.width;
            setState(() {});
          }
        },

Cheers

@p4-k4 p4-k4 added the enhancement New feature or request label Mar 31, 2023
@ujas-m-simformsolutions
Copy link
Collaborator

@p4-k4 thank you for your suggestion. Your implemention works for only WaveformType.fitWidth so I will update the logic and will create a PR

@pbaudri
Copy link

pbaudri commented Jul 4, 2023

Any news about this update ?

@alexboulay
Copy link

@ujas-m-simformsolutions any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants