From 1986e12d78ac3af762579e525db0c71e79ffc120 Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Wed, 20 Jan 2021 01:15:27 +0100 Subject: [PATCH 1/5] Make it work with Crystal nightlies (0.36.0) again --- src/raven/log_backend.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/raven/log_backend.cr b/src/raven/log_backend.cr index fa27d19..0c0ac75 100644 --- a/src/raven/log_backend.cr +++ b/src/raven/log_backend.cr @@ -53,7 +53,7 @@ module Raven # See `Event#logger`, `Breadcrumb#category` property default_logger : String - {% if compare_versions(Crystal::VERSION, "1.0.0-dev") >= 0 %} + {% if compare_versions(Crystal::VERSION, "0.35.1") > 0 %} def initialize( dispatch_mode : ::Log::DispatchMode = :sync, *, From c85acdbfc69eeb6202244763b8e7415db92f057e Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Wed, 20 Jan 2021 01:16:13 +0100 Subject: [PATCH 2/5] Optimize map + join call --- src/raven/integrations/http/handler.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/raven/integrations/http/handler.cr b/src/raven/integrations/http/handler.cr index b61afd4..18ed842 100644 --- a/src/raven/integrations/http/handler.cr +++ b/src/raven/integrations/http/handler.cr @@ -30,7 +30,7 @@ module Raven end protected def cookies_to_string(cookies : HTTP::Cookies) - cookies.to_h.map(&.last.to_cookie_header).join "; " + cookies.to_h.join("; ") { |_, cookie| cookie.to_cookie_header } end abstract def build_raven_culprit_context(context : HTTP::Server::Context) From 2dc7cd687620459f6c958ce8f69ef6c1a16894da Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Mon, 25 Jan 2021 21:36:38 +0100 Subject: [PATCH 3/5] Shorten up couple of block calls --- src/raven/interfaces/message.cr | 4 ++-- src/raven/processors/utf8_conversion.cr | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/raven/interfaces/message.cr b/src/raven/interfaces/message.cr index 5c3becb..63f9519 100644 --- a/src/raven/interfaces/message.cr +++ b/src/raven/interfaces/message.cr @@ -8,8 +8,8 @@ module Raven end def unformatted_message - if params = @params - params.empty? ? message? : message?.try { |m| m % params } + if (params = @params) && !params.empty? + message?.try(&.%(params)) else message? end diff --git a/src/raven/processors/utf8_conversion.cr b/src/raven/processors/utf8_conversion.cr index ffe1e4f..c1d0600 100644 --- a/src/raven/processors/utf8_conversion.cr +++ b/src/raven/processors/utf8_conversion.cr @@ -12,9 +12,9 @@ module Raven when Exception return data unless message = data.message return data if message.valid_encoding? - data.class.new(clean_invalid_utf8_bytes(message), data.cause).tap do |ex| - ex.callstack = data.callstack - end + data.class + .new(clean_invalid_utf8_bytes(message), data.cause) + .tap(&.callstack=(data.callstack)) when String return data if data.valid_encoding? clean_invalid_utf8_bytes(data) From f10889123ffa1eb3d2c8ff41b2fa98973d85b171 Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Mon, 25 Jan 2021 22:01:42 +0100 Subject: [PATCH 4/5] Avoid crashing the formatter :/ --- src/raven/interfaces/message.cr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/raven/interfaces/message.cr b/src/raven/interfaces/message.cr index 63f9519..9ec4d01 100644 --- a/src/raven/interfaces/message.cr +++ b/src/raven/interfaces/message.cr @@ -9,7 +9,7 @@ module Raven def unformatted_message if (params = @params) && !params.empty? - message?.try(&.%(params)) + message?.try(&.% params) else message? end From 52da35238a15663425e4e3575567177125387a17 Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Wed, 27 Jan 2021 14:39:29 +0100 Subject: [PATCH 5/5] Bump to v1.9.1 --- shard.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shard.yml b/shard.yml index fcfa20e..63b9d1a 100644 --- a/shard.yml +++ b/shard.yml @@ -1,5 +1,5 @@ name: raven -version: 1.9.0 +version: 1.9.1 authors: - Sijawusz Pur Rahnama