Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit definitions for Arduino framework setup() and loop() functions #462

Closed
mairas opened this issue Nov 6, 2021 · 1 comment
Closed

Comments

@mairas
Copy link
Collaborator

mairas commented Nov 6, 2021

I'm just linking this related ReactESP issue here for more publicity: mairas/ReactESP#16

The benefits are listed in the issue. The drawbacks that I can immediately think of would be:

  • This would be a breaking change in ReactESP. Any users would need to declare the dependency to ReactESP major version to avoid breaking existing code. In platformio.ini lib_deps: mairas/ReactESP @ ^1.0.0. But at the moment nobody has that, so they'd find it out by having code that stops compiling.
  • This would also be a breaking change in SensESP 2.0. Software would need to be modified to use setup() and loop() instead of the current ReactESP app(lambda); syntax.
@mairas
Copy link
Collaborator Author

mairas commented Nov 29, 2021

Fixed in #475.

@mairas mairas closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant