Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate code for sequence_runtime_check #4

Open
lukasc-ubc opened this issue May 25, 2024 · 1 comment
Open

duplicate code for sequence_runtime_check #4

lukasc-ubc opened this issue May 25, 2024 · 1 comment

Comments

@lukasc-ubc
Copy link
Member

@JymBone5

I notice that sequence_runtime_check() appears as a duplicate in both sequencecreator.py, and yamlcheck.py. I suggest moving most of the calculations out of the GUI code from the logic code. So the GUI should refer to yamlcheck.sequence_runtime_check().

Thank you
@lukasc-ubc
Copy link
Member Author

I have made some progress on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukasc-ubc