Add default value to Context::scope parameter to make it optional #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes:
ShopifyApp.configure
if we already declare them on the.toml
config file? shopify_app#1912Background
The
scope
parameter was required as a part of the legacy OAuth flow (Authorization code grant). It's a required parameter during theShopifyAPI::Context
setup process. It can be set to[]
or""
.We don't have to enforce
scope
in the setup with Shopify managed install since scopes are configured in theshopify.app.*.toml
files already.Solution
Making this field to have a default value so it can be omitted during setup.
How has this been tested?
shopify-api-ruby
with my changes to my appscope
setup in theShopifyAPI::Context.setup
Configuration without
scopes
Checklist: