Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Session Cookie Value While Embedded Mode Allows Fallback #1206

Closed

Conversation

berniechiu
Copy link

@berniechiu berniechiu commented Aug 29, 2023

Description

Fixes #1158

Please, include a summary of what the PR is for:

  • What is the problem it is solving?
    Embedded mode allows session cookie fallback, but we don't assign anything to the cookie under embedded mode.
  • What is the context of these changes?
    Make cookie creation consistent with session.
  • What is the impact of this PR?
    Make the fallback work as usual.

How has this been tested?

Please, describe the tests that you ran to verify your changes.

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@berniechiu berniechiu changed the title Cookie Value Should Stay Consistent Since Embedded Mode Allows Fallback Consistent Cookie Value While Embedded Mode Allows Fallback Aug 29, 2023
@berniechiu berniechiu changed the title Consistent Cookie Value While Embedded Mode Allows Fallback Consistent Session Cookie Value While Embedded Mode Allows Fallback Aug 29, 2023
@berniechiu berniechiu force-pushed the fix/nil-cookie-for-the-fallback branch from b811279 to 7f5d228 Compare August 29, 2023 14:36
@berniechiu berniechiu force-pushed the fix/nil-cookie-for-the-fallback branch from 7f5d228 to 43ab21f Compare August 29, 2023 14:37
@lizkenyon
Copy link
Contributor

Hi there 👋

Thank you for submitting this PR, but we can't accept it at this time.
We removed the use of cookies for embedded apps because browsers are phasing out(or already have) the use of third party cookies due to security concerns.

This is why we introduced App Bridge.

If you are looking at how to implement this in Ruby, I would recommend looking at our app template.

@lizkenyon lizkenyon closed this Dec 8, 2023
@berniechiu
Copy link
Author

Well...if I may clarify, the code still present in the Shopify API Ruby, no? If it has not been removed, this could potentially lead to confusion and logical inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies Fallback Doesn't Work in Shopify App under Embedded Mode
2 participants