Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 5.8.0 breaking authentication and GraphQL API queries #385

Closed
1 task done
myworks-peter opened this issue Nov 13, 2024 · 1 comment · Fixed by #387
Closed
1 task done

version 5.8.0 breaking authentication and GraphQL API queries #385

myworks-peter opened this issue Nov 13, 2024 · 1 comment · Fixed by #387

Comments

@myworks-peter
Copy link

myworks-peter commented Nov 13, 2024

Issue summary

We just auto-updated to v5.8.0 in a standard deploy last night, and then noticed that all of a sudden we were having both session/authentication issues with our embedded app in Shopify, as well as issues with GraphQL queries failing inside of our app.

After an extreme amount of troubleshooting, we realized that hardcoding v5.7.0 of this library in our app resolved the above issues.

Expected behavior

Not breaking API calls

Actual behavior

  • Authentication/session issue in Shopify resulting in embedded app not loading within Shopify; with a 401 Unauthorized error in the console
  • GraphQL API queries resulting in a 400 Bad Request message from Shopify;
  • The below error occurring:
    Syntax error {"exception":"[object] (JsonException(code: 4): Syntax error at /var/app/current/vendor/shopify/shopify-api/src/Clients/HttpResponse.php:48)

Steps to reproduce the problem

  1. Create a basic installation of the php template following the instructions here: https://github.com/Shopify/shopify-app-template-php
  2. Try to run the project.

Checklist

  • I have described this issue in a way that is actionable (if possible)
@myworks-peter myworks-peter changed the title version 5.8.0 including breaking changes version 5.8.0 breaking authentication and GraphQL API queries Nov 13, 2024
@lizkenyon
Copy link
Contributor

Hi there 👋

Sorry about this. A fix should now be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants