Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill conflicts with ThreadWebWorker #488

Closed
j4m3sb0mb opened this issue Nov 13, 2024 · 1 comment · Fixed by #499
Closed

Polyfill conflicts with ThreadWebWorker #488

j4m3sb0mb opened this issue Nov 13, 2024 · 1 comment · Fixed by #499

Comments

@j4m3sb0mb
Copy link

It seems that @remote-dom/core/polyfill is conflicting with ThreadWebWorker from @quilted/threads in a WebWorker. The issue appears to be that the polyfill overrides the self variable, causing ThreadWebWorker to stop listening for messages from the DOM.

@lemonmade
Copy link
Member

@j4m3sb0mb thank you for raising the issue, and sorry for not getting back to you sooner! The PR linked above gives some details on what caused this, and how we are rolling it back (we intend to make the same change again in the future, but with an alternative approach to applying the polyfill that will allow it to work more seamlessly with libraries that require access to the original globalThis/ globalThis.self from the Web Worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants