You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
it('does not confuse KaiOS with iOS',()=>{constbrowser=newBrowser({userAgent:
'Mozilla/5.0 (Mobile; rv:37.0; 4044V) Gecko/68.0 Firefox/101.0 KaiOS/1.0',});expect(browser.os).toBe('KaiOS');expect(browser.isIOS).toBe(false);// currently this fails});
Note: It looks like the newer versions of KaiOS might have been flagged as Android instead, so not sure how much impact of this bug would be.
Consuming repo
What repo were you working in when this issue occurred?
N/A, just from reviewing the code
Checklist
Please delete the labels section before submitting your issue
I have described this issue in a way that is actionable (if possible)
The text was updated successfully, but these errors were encountered:
Overview
When
ua-parser-js
returnsKaiOS
,browser.isIOS
istrue
instead offalse
.This is because we use
.includes
instead of equal on this line in browser.tsExample of user agents that would result in the bug
Mozilla/5.0 (Mobile; rv:37.0; 4044V) Gecko/68.0 Firefox/101.0 KaiOS/1.0
Mozilla/5.0 (Mobile; Nokia_8110_4G; rv:48.0) Gecko/48.0 Firefox/48.0 KAIOS/2.5
Example failing test:
Note: It looks like the newer versions of KaiOS might have been flagged as
Android
instead, so not sure how much impact of this bug would be.Consuming repo
N/A, just from reviewing the code
Checklist
The text was updated successfully, but these errors were encountered: