Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalars in mixed type expressions not correctly implemented #2

Open
Ulfgard opened this issue Mar 4, 2017 · 1 comment
Open

scalars in mixed type expressions not correctly implemented #2

Ulfgard opened this issue Mar 4, 2017 · 1 comment
Labels

Comments

@Ulfgard
Copy link
Member

Ulfgard commented Mar 4, 2017

This is a universal problem occuring at several places.

In general scalar arguments are treated as having the same type as the scalar of the matrix. This is often correct. In expressions as

a*X where X stores integer and a is a real number, this will result in a being cast to an integer and the whole expression does not lead to the correct result.

Worse, all assign functions treat arguments as having the same scalar type. So even fixing a*X will not always result into the right value.

@Ulfgard Ulfgard added the bug label Mar 4, 2017
@Ulfgard
Copy link
Member Author

Ulfgard commented Apr 13, 2017

This is mostly fixed now.

Assignment functions now take the scalar argument as the scalar type of the left hand side

what is missing are the scalar operators of the noalias proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant