Cache the height of the ad for the homework and timetable page banner #1772
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 16, 2024
## Description This PR adds a placeholder when the ads are loading. However, for the homework and timetable page, we don't know the height at the beginning. This depends on the device height. In the future, we could also cache this information (I already created a ticket: #1772). ## Demo ### iPhone https://github.com/user-attachments/assets/6bea572a-2270-4063-8a12-8f9c27a31b22 ### iPad Pro 13" https://github.com/user-attachments/assets/8ec4842a-ba4d-47c5-aa86-94f1c2bf6c75 ### iPhone SE https://github.com/user-attachments/assets/888c503e-c8bb-4cc0-8866-c7bf50874fdc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As mentioned in #1771 the height of the banner on the homework and timetable page is different for every screen height. However, to provide a better UX we could cache the ad height. There, we don't have this small jump in the layout anymore.
The text was updated successfully, but these errors were encountered: