Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librdkafka? #32

Open
chuck-alt-delete opened this issue Feb 1, 2022 · 2 comments
Open

Update librdkafka? #32

chuck-alt-delete opened this issue Feb 1, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@chuck-alt-delete
Copy link

The version of librdkafka seems fixed at 1.4.2, which is about a year and a half old at this point. Any reason not to use a newer version? Maybe this can be incorporated into CI?

Also, all the examples show compiling librdkafka from source. Any reason not to install it with a package manager?

@JonZeolla
Copy link
Member

JonZeolla commented Feb 2, 2022

@chuck-alt-delete yeah that shouldn't be a problem. To run the tests with a new version the only update is to https://github.com/SeisoLLC/zeek-kafka/blob/main/docker/docker-compose.yml#L49

@chuck-alt-delete
Copy link
Author

chuck-alt-delete commented Feb 2, 2022

Thanks Jon!

Sort of related is:

If docker image artifacts are published somewhere, maybe it makes sense to have images with different versions of zeek and different versions of librdkafka so people can pull off the shelf a trusted, well-tested image with the version combo they need?

@ottobackwards ottobackwards added enhancement New feature or request help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants