fix: update device UUID extraction logic in BaseService #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the method of extracting the device UUID from the MAC address in the BaseService class. The extraction now uses the last segment of the MAC address instead of the third segment, ensuring correct UUID retrieval for device control and info requests.
SecKatie
commented
Dec 8, 2024
|
Sorry I just saw the emails about this. I don't see anything in the code that should be an issue. As long as the last segment will be the right segment for everything. (Not sure as I don't use wyze devices much lately) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the method of extracting the device UUID from the MAC address in the BaseService class. The extraction now uses the last segment of the MAC address instead of the third segment, ensuring correct UUID retrieval for device control and info requests.