You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we execute forge coverage based on the existing test suite, many tests revert when VotingTokenConcrete::transfer is called.
Subsequent execution of forge test will return the same errors.
The tests will pass again after execution of forge clean.
We also encounter the same behavior if we set via_ir in foundry.toml to false.
My guess is that forge coverage can only be executed with via_ir set to false.
What I am not sure is if this is a problem the test suite had to begin with, or this is some problem with foundry.
The test suite uses Solmate implementation of ERC20, while the VotingTokenConcrete contract uses OpenZeppelin implementation of ERC20, presumably to enable the ERC20Votes extension.
The text was updated successfully, but these errors were encountered:
funkyenough
changed the title
forge coverage cause safeTransfer to fail in existing test suites
WIP: forge coverage cause safeTransfer to fail in existing test suites
Jan 24, 2025
If we execute
forge coverage
based on the existing test suite, many tests revert whenVotingTokenConcrete::transfer
is called.Subsequent execution of
forge test
will return the same errors.The tests will pass again after execution of
forge clean
.We also encounter the same behavior if we set
via_ir
infoundry.toml
to false.My guess is that
forge coverage
can only be executed withvia_ir
set to false.What I am not sure is if this is a problem the test suite had to begin with, or this is some problem with foundry.
The test suite uses
Solmate
implementation ofERC20
, while theVotingTokenConcrete
contract usesOpenZeppelin
implementation ofERC20
, presumably to enable theERC20Votes
extension.The text was updated successfully, but these errors were encountered: