Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize and document FunctionOperator constructor #162

Open
gaurav-arya opened this issue Mar 12, 2023 · 2 comments
Open

Finalize and document FunctionOperator constructor #162

gaurav-arya opened this issue Mar 12, 2023 · 2 comments

Comments

@gaurav-arya
Copy link
Member

gaurav-arya commented Mar 12, 2023

The constructor is currently not documented, and accepted_kwargs is also a little awkward (inconsistent with its other usages too, since this one takes in both the fields and the values). We should revisit this soon and finalize the interface.

@vpuri3
Copy link
Member

vpuri3 commented Mar 12, 2023

thanks

@gaurav-arya
Copy link
Member Author

We should also handle #57 when doing this -- I think it's an important issue. But the current version looks good enough to start propagating through SciML, so we can leave this alone for a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants