No support for ed25519-sk ssh keys

[timhorn1]

[INFO]    [createSocket(tr3_config)] Creating socket
[DEBUG]   [createSocket(tr3_config)] Connecting to 192.168.178.70:22
[INFO]    [createSSH(tr3_config)] Flag "OPENSSH-SHA1" enabled due to 'missing', including convertSha1 for publickey authentication
[INFO]    [createSSH(tr3_config)] Flag "OPENSSH-SHA1" enabled due to 'missing'
[ERROR]   Error while connecting to SSH FS tr3_config:
Error: Cannot parse privateKey: **Unsupported OpenSSH private key type: [email protected]**
Error: Cannot parse privateKey: Unsupported OpenSSH private key type: [email protected]
	at e.exports.connect (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/14f8.extension.js:1:87603)
	at /home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/14f8.extension.js:1:63301
	at new Promise (<anonymous>)
	at I (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/14f8.extension.js:1:61446)
	at async g._createConnection (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:1:59429)
Caused by catchingPromise:
	at /home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:11:6594
	at Promise.catch.o (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:11:6684)
	at new Promise (<anonymous>)
	at i (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:11:6399)
	at E.createFileSystem (/home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:1:64587)
Logged at:
	at /home/timh/.vscode-oss/extensions/kelvin.vscode-sshfs-1.26.1/dist/extension.js:1:66250

[Fischmuetze]

same here - sad - therefore currently unusable

[SchoofsKelvin]

This might be the same issue as (or cause of) #435. I don't have a physical security key nor does the extension's underlying ssh2 library seem to support it (mscdex/ssh2#1206) so it'll be tricky. I'll take a look at whether I can test it myself and work around the issue.

[SchoofsKelvin]

Looked a bit into patching it into ssh2 myself, two main points regarding that:

• Having the extension directly use sk-* private keys is basically impossible, as it needs to interact with the OS in some way to actually use the private key (i.e. Windows Hello, talk with a Yubi key, ...). I highly doubt that'll be added anytime soon, if at all. I don't see an easy way to do this either, let alone get it working cross-platform and publishable with the extension.
• I succeeded in getting it mostly working with the OpenSSH agent on Windows (i.e. ssh-add) which therefore should work on Mac/Linux too. I say mostly, as I succeeded in getting and parsing the public sk-* from the agent, exchanging it with the remote server, signing using the private key locally (through the agent), but my test server complains the signature is in the wrong format, so something's still wrong. Might look more into it, unlikely to be done (properly) soon, but there's at least a good possibility.