Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToDo list for next update #13

Open
8 of 18 tasks
TCLamnidis opened this issue Sep 2, 2024 · 3 comments
Open
8 of 18 tasks

ToDo list for next update #13

TCLamnidis opened this issue Sep 2, 2024 · 3 comments

Comments

@TCLamnidis
Copy link
Collaborator

TCLamnidis commented Sep 2, 2024

nf-core/eager prep:

  • Swap to using pandora2eager instead of its predecessor. This mostly updates the pickup of strandedness, udg treatment, and colour chemistry for newer protocols/sequencers.
  • Change reverse adapter for ssDNA PE data.

Poseidon packages:

  • collecting ssDNA and dsDNA genotypes in each package (there should be no clashing sample IDs anymore) (Single stranded sample name change in eager processing #8)
    • Collecting the genotypes for poseidon package creation
    • Janno fill-in for both versions
  • Bump created packages to Poseidon version 2.7.0 (currently still 2.5.0)

PDF Reports:

Phenotypic SNPs:

Processing:

@TCLamnidis
Copy link
Collaborator Author

TCLamnidis commented Sep 3, 2024

Using pandora2eager for TSV preparation actually revealed a small bug. The previous approach required some manual tweaks for certain samples, and hence some Sample_IDs did not get the appropriate suffix. This is not an issue until genotypes are collected together, but might require some slight reprocessing to fix properly.

UPDATE:
Upon further inspection, the only batches where there is a mix of dsDNS and ssDNA data, and suffixes were accidentally skipped are:
2023-11-07-bulgaria
2021-01-04-austria
In both cases, the individuals that missed the suffix did not have a dsDNA equivalent, and hence no results were lost/hidden, just the naming was inconsistent in the resulting poseidon packages.

This means that no reprocessing will be necessary to merge dsDNA and ssDNA genotypes in the new poseidon packages!

@stschiff
Copy link

stschiff commented Sep 9, 2024

OK, but just to clarify: You did not fix the _ss suffix where they were missing now? I think that's OK, just want to be sure.

@TCLamnidis
Copy link
Collaborator Author

I had not, until now.
Both of the aforementioned batches needed reprocessing to fix ssDNA/PE adapter leftovers, so I took the opportunity to also fix the suffixes for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants