You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Fields class in Cascading 2.2 and later supports optional field type declarations. However, when I tried to use avro-scheme with an application that makes use of this feature, it failed. The reason is a bit hard to explain, but this is the general idea:
When Cascading encounters a mix of typed and untyped Fields in a flow it will generally drop the field types.
The AvroScheme generates an untyped Fields object.
Therefore, the tuples sourced from the scheme cause pipes to fail downstream if they rely on the field types facility for type coercion.
I don't feel that this is ready for a merge just yet, because:
I started my work on the version-2.5 branch and I haven't yet digested the type conversion logic going on in version-2.6 and how this might affect what I'm doing.
I haven't yet thought out how to unit test these field typing changes
Yet I think it's a good time already to start the conversation on how to move forward from here on getting this feature merged upstream.
See also the discussion under issue #27 for other potential expansions of this feature.
The text was updated successfully, but these errors were encountered:
A first step would be to define a good test for merging a Pipe sourced from Avro with a pipe that has typed fields, and ensure that we don't wind up with untyped fields downstream. One way might be to have a custom function that checks field types for the tuples it receives.
The
Fields
class in Cascading 2.2 and later supports optional field type declarations. However, when I tried to useavro-scheme
with an application that makes use of this feature, it failed. The reason is a bit hard to explain, but this is the general idea:Fields
in a flow it will generally drop the field types.AvroScheme
generates an untypedFields
object.For more background, see these links:
I have started a branch of
avro-scheme
that generates typed fields:I don't feel that this is ready for a merge just yet, because:
version-2.5
branch and I haven't yet digested the type conversion logic going on inversion-2.6
and how this might affect what I'm doing.Yet I think it's a good time already to start the conversation on how to move forward from here on getting this feature merged upstream.
See also the discussion under issue #27 for other potential expansions of this feature.
The text was updated successfully, but these errors were encountered: