-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show content in cutout area toggle missing? #13
Comments
Can you provide more details and screenshots as I don't really get what feature are you referring to?
Maybe also show a comparison between upstream and J2K?
|
So this is best viewed on a mobile device with a notch when viewing the screenshots. 1st) Fullscreen enabled and show content in cutout enabled For the 1st screenshot this is the default viewing experience when Fullscreen is enabled and the toggle for show content in cutout area is enabled I've noticed Yokai has implemented this recently and even added further support than what Mihon/Tachiyomi has done so far, unfortunately the app doesn't seem to have a clear goal so I'd much rather see it implemented in a stable fork like this one |
One quirk, I have noticed with the way tachiyomi's full screen toggle works is that it will always display the notification icons as shown in the screenshot below This is when the full screen toggle is set to off in tachiyomi In the newer versions of tachiyomi with the new "display content in cutout area" toggle set to off, this hides the notification content for just a solid black bar |
Unfortunately this option requires me to have an android device. I only use WSA and the cutout setting is hidden there because its not applicable. Feel free to develop this feature and submit a PR if you are interested. I don't plan to develop it anytime soon. |
Describe your suggested feature
This is a toggle that is present in the new versions of tachiyomi, but not in the current versions of J2K.
What makes this different from the current full screen toggle in tachiyomi is that it completely blacks out the cutout area. Whereas the full screen toggle gives it a grayscale like appearance and it applies to the entire app.
I've looked through Jays2Kings issues on github and found that he did Implement the toggle somewhat but only for landscape mode. So what I'm asking is for the same functionality in portrait mode if it's feasible
Other details
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: