Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return types in load_model function #66

Open
Sasafrass opened this issue Jul 22, 2021 · 0 comments
Open

Add return types in load_model function #66

Sasafrass opened this issue Jul 22, 2021 · 0 comments
Assignees
@annaproxy @Sasafrass
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed Refactor This PR focuses (mostly) on refactoring of code

Comments

@Sasafrass
Copy link
Owner

For clarity and maintainability purposes we should add return types to the load_model function in https://github.com/Sasafrass/straattaal/blob/9bf261746a020569a0dcf7ecc2c3a26dec1fc376/app/ml_models/rnn/loaded_rnn_model.py
@Sasafrass Sasafrass added documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers Refactor This PR focuses (mostly) on refactoring of code labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annaproxy annaproxy

@Sasafrass Sasafrass

Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed Refactor This PR focuses (mostly) on refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annaproxy @Sasafrass