-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fonts #8
Comments
|
The last bits of polish took a big lot of hurt wrangling the swamp of frameworks at play… 😣 |
Haven't checked the code but that looks pretty neat. Well poke at in some time later. It's a bit difficult to get to stuff for me, alas. Not sure what frameworks you mean? There's Vue and Bootstrap, but neither need extra setup... Rewriting the entire thing to use neither would be a nightmare. Input handling alone is rather difficult. Having to reimplement the list generation, handling and rendering in "raw" TypeScript and HTML does not sound like a fun time for me, either. |
There's also a serif font featured on page 36.
There's still bugs in there and I'm butchering some things in the process but if you wanted to yoink the font assets — you could sleuth them out. I've done away with arbitrary absolute inline constants and try to reuse a predefined set of algebraically-derived ones instead. Could still be done better. A gigantic problem I experienced in altering the font is that you seem to have reimplemented your font three different times with three separate approaches through three disparate APIs for corresponding contexts and it's such a headache to hunt it down all strewn around the project and duplicate changes over and over… There needs to be one generalized function for rendering one asset per font. Be it with polymorphism and control flow routes as needed. I couldn't find the strength to generalize and combine them all yet.
Look, I don't want you to take my criticisms as offence and don't expect you to remake it. But from where I stand, even not being a prolific frontender myself, I do, quite on the contrary to your reprehension of the idea, see it as very straightforward to implement all of it in basic frameworkless clientside APIs, not even TS is a must, even if neat. Anyway, again, not trying to be pushy, just sharing my thoughts. |
I know you got enough on your platter, so I'm just leaving this suggestion for later.
Implement the cursive font found on manual pages 21 and… I forget the other one… and the isocube font found on pages 6 and 41.
I'm a fan of the latter personally. No edge segmentation or overlaps to worry about…
I saw another webapp (straight up translator I think, haven't used it) implement the cursive one.
The text was updated successfully, but these errors were encountered: