Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout: modern-side planning phase and button placement #305

Closed
Samillion opened this issue Jan 11, 2025 · 18 comments
Closed

Layout: modern-side planning phase and button placement #305

Samillion opened this issue Jan 11, 2025 · 18 comments
Labels
question Questions relating to ModernZ osc or its configuration

Comments

@Samillion
Copy link
Owner

Samillion commented Jan 11, 2025

At the moment, ModernZ implements chapter skip buttons in the center

image

On mpv's stock osc, it's like this:

image

Why am I considering this idea:

  • It places relative buttons in the focused area, where they're needed
  • It reduces footprint of buttons
  • It would allow in the future to add a "side" layout, where the controls are shown similar to Youtube, without it being too crowded

So they would be added left of chapter title, with a matching size in:

image

@Samillion Samillion added feature request New feature or request question Questions relating to ModernZ osc or its configuration and removed feature request New feature or request labels Jan 11, 2025
@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

Sure. That wouldn't be bad.

If placed there, they would no longer be grayed out when no chapter exists? Rather the buttons would be hidden entirely.

@Samillion
Copy link
Owner Author

Indeed. I'll even try to find simplified alternative icons to match the area.

I'll wait a while before actually starting to implement this, to get a general sense from feedback (if any), and if it would be an actual good decision or not.

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

It may even prompt someone to ask for the same treatment of [playlist_prev] [playlist_next] [show_title]

Arguably it might look a little busy having multiple arrows up there.

@Samillion
Copy link
Owner Author

Sexactly!

Honestly though, the reason I'm hesitant about chapter skip buttons placement is that I never use them. If I was maintaining ModernZ for my own personal use only, I would have removed them long ago lol.

That's why I'm trying to get a general feel on this to not let my own bias affect the decision.

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

Explains why they're disabled by default haha.

It would be more obvious on what the buttons do because they'd be beside chapter title. Less confusing for a new user.

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

It should probably check for show_chapter_title and if set to no, put them back in the center?

@Samillion
Copy link
Owner Author

Samillion commented Jan 11, 2025

It should probably check for show_chapter_title and if set to no, put them back in the center?

Good point.

So it needs to address that scenario, especially if a side buttons layout is added.

[play_pause] [playlist_prev] [playlist_next] [skip_back] [skip_forward] [chapter_prev] [chapter next]

That's initially what made me hesitant, becoming too crowded on the side. But I guess that's only if they're all enabled.

Explains why they're disabled by default haha.

Tehehe

image

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

image

Play button can even go in the middle. Chapter title at the end.

Have to find a spot for mpv-player/mpv#15499 eventually.

@Samillion
Copy link
Owner Author

Samillion commented Jan 11, 2025

Yeah, it looks amazing when it's compact like that.

Hmmm. The use of > indicator is interesting. Would relying on toggle select menu for chapters, instead of the chapter buttons be a good idea? Basically what we have now, just with an indicator to show "there are more chapters ahead".

Edit:
< chapter_title >

Actually, they can each be their own button. Interesting.

@Keith94
Copy link
Contributor

Keith94 commented Jan 11, 2025

It wouldn't be bad to have that visual indicator, since the chapter skip functions can be implemented in other ways.

In my config I could possibly set the mouse actions like this (need to add middle button action)..

chapter_title_mbtn_left_command=add chapter -1
chapter_title_mbtn_mid_command=add chapter 1
chapter_title_mbtn_right_command=script-binding select/select-chapter; script-message-to modernz osc-hide

@da3dsoul1
Copy link

I want them to be here! Here's my idea of how I would like things to be
image

@Samillion
Copy link
Owner Author

Samillion commented Jan 13, 2025

Yeah, that's the future plan for adding a "side buttons" layout.

This is basically the phase before it, planning the layout.

When it's implemented, basically the user can switch layouts between modern and modern-side within modernz.conf

# not implemented yet
# accepts modern and modern-side
layout=modern

@da3dsoul1
Copy link

Cool, thanks for your work! Best osc out there!

@Xurdejl
Copy link
Contributor

Xurdejl commented Jan 14, 2025

Personally, I never use the chapter buttons. I either use the hotkeys or, in case I use the mouse, I click on the chapter title for the interactive menu.

@Samillion
Copy link
Owner Author

Samillion commented Jan 14, 2025

Indeed.

I think for modern-side I'll just move them to the side before doing any major changes/additions. Since the user has full control on which buttons to appear.

Most players include the following by default

[play_pause] [playlist_prev] [playlist_next]

Left side full layout:

[play_pause] [playlist_prev] [playlist_next] [skip_back] [skip_forward] [chapter_prev] [chapter_next]

Right side full layout:

[cache] [download] [loop] [speed] [screenshot] [pin] [audio] [subs] [playlist] [info] [fullscreen]

@Samillion
Copy link
Owner Author

Samillion commented Jan 14, 2025

Also, for modern-side, we can condition some buttons.

For example, playlist_prev and playlist_next

Logic:

  • If there are no previous files within the playlist, don't show it. Same for next
    • Which applies for chapter skip as well
  • Only show next and prev related buttons if one of the conditions exist, as in: no grayed out buttons display

@Samillion Samillion changed the title Should chapter skip buttons be next of chapter title? Layout: modern-side planning phase and button placement Jan 14, 2025
@Keith94
Copy link
Contributor

Keith94 commented Jan 14, 2025

Good ideas. Probably will need a few changes to the side_buttons_color = and middle_buttons_color = for the different layouts as well.

@Samillion
Copy link
Owner Author

True, and it'll workout for all layouts. We can introduce:

left_side_buttons_color=#FFFFFF
right_side_buttons_color=#FFFFFF

Repository owner locked and limited conversation to collaborators Jan 23, 2025
@Samillion Samillion converted this issue into discussion #334 Jan 23, 2025

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
question Questions relating to ModernZ osc or its configuration
Projects
None yet
Development

No branches or pull requests

4 participants