-
Notifications
You must be signed in to change notification settings - Fork 10
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout: modern-side planning phase and button placement #305
Comments
Sure. That wouldn't be bad. If placed there, they would no longer be grayed out when no chapter exists? Rather the buttons would be hidden entirely. |
Indeed. I'll even try to find simplified alternative icons to match the area. I'll wait a while before actually starting to implement this, to get a general sense from feedback (if any), and if it would be an actual good decision or not. |
It may even prompt someone to ask for the same treatment of Arguably it might look a little busy having multiple arrows up there. |
Sexactly! Honestly though, the reason I'm hesitant about chapter skip buttons placement is that I never use them. If I was maintaining ModernZ for my own personal use only, I would have removed them long ago lol. That's why I'm trying to get a general feel on this to not let my own bias affect the decision. |
Explains why they're disabled by default haha. It would be more obvious on what the buttons do because they'd be beside chapter title. Less confusing for a new user. |
It should probably check for |
Good point. So it needs to address that scenario, especially if a side buttons layout is added.
That's initially what made me hesitant, becoming too crowded on the side. But I guess that's only if they're all enabled.
Tehehe |
Play button can even go in the middle. Chapter title at the end. Have to find a spot for mpv-player/mpv#15499 eventually. |
Yeah, it looks amazing when it's compact like that. Hmmm. The use of Edit: Actually, they can each be their own button. Interesting. |
It wouldn't be bad to have that visual indicator, since the chapter skip functions can be implemented in other ways. In my config I could possibly set the mouse actions like this (need to add middle button action)..
|
Yeah, that's the future plan for adding a "side buttons" layout. This is basically the phase before it, planning the layout. When it's implemented, basically the user can switch layouts between # not implemented yet
# accepts modern and modern-side
layout=modern |
Cool, thanks for your work! Best osc out there! |
Personally, I never use the chapter buttons. I either use the hotkeys or, in case I use the mouse, I click on the chapter title for the interactive menu. |
Indeed. I think for Most players include the following by default
Left side full layout:
Right side full layout:
|
Also, for For example, Logic:
|
Good ideas. Probably will need a few changes to the side_buttons_color = and middle_buttons_color = for the different layouts as well. |
True, and it'll workout for all layouts. We can introduce: left_side_buttons_color=#FFFFFF
right_side_buttons_color=#FFFFFF |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
At the moment, ModernZ implements chapter skip buttons in the center
On mpv's stock osc, it's like this:
Why am I considering this idea:
So they would be added left of chapter title, with a matching size in:
The text was updated successfully, but these errors were encountered: