Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build into docker image #46

Open
mariogarridopt opened this issue Sep 14, 2023 · 1 comment
Open

Build into docker image #46

mariogarridopt opened this issue Sep 14, 2023 · 1 comment

Comments

@mariogarridopt
Copy link

I believe that this Python bot could easily be encapsulated into a docker container, this would bring a few advantages:

  1. Easy to install or launch, for example:
docker run -it voicemaster
  1. Since you do not expect active development for this code it would be cool if we could freeze it into some Python version, using a build container.

If you think this is a good idea I'm sure someone will pick this issue.
Just curious about your opinion and if you like it, what would be your rules/constraints.

@SamSanai
Copy link
Owner

Hi @mariogarridopt, I believe containerizing applications is very useful and an excellent idea.

Although I had previously stated, the repository won't be getting any updates, there's a chance I will consider pulling #45 as it only updates the state of the code and makes it more efficient, upon proper inspection of course when I get the chance.

I would not be against having it containerized, either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants