Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Language on Android Broken #76

Open
djhalliday opened this issue Sep 2, 2011 · 4 comments
Open

Changing Language on Android Broken #76

djhalliday opened this issue Sep 2, 2011 · 4 comments

Comments

@djhalliday
Copy link
Member

Changing languages within the settings dialog still doesn't seem to be quite right - appears to be reading from the wrong .xml file when selecting an option. Needs to be fixed ASAP for int'l beta testing.

@ghost ghost assigned harlo Sep 2, 2011
@harlo
Copy link
Contributor

harlo commented Sep 2, 2011

I cleaned up the string resource files with the hopes that consolidating the resources would prevent app from loading the wrong xml files. I can't replicate this problem on my build though. What resource did it attempt to load when you noticed the error?

@djhalliday
Copy link
Member Author

Great! yes it seems to work well for English, Arabic and Farsi. I was trying to add Simplified Chinese and it's not taking. What else do I need to add besides an entry into strings.xml and the correct values- folder with translated itc_strings.xml?

@harlo
Copy link
Contributor

harlo commented Sep 2, 2011

Make sure you change the "strings.xml" values in each language's folder? If
you are still stuck, I can take a crack at it when you push to master next
time.

On Fri, Sep 2, 2011 at 4:20 PM, djhalliday <
[email protected]>wrote:

Great! yes it seems to work well for English, Arabic and Farsi. I was
trying to add Simplified Chinese and it's not taking. What else do I need to
add besides an entry into strings.xml and the correct values- folder with
translated itc_strings.xml?

Reply to this email directly or view it on GitHub:
#76 (comment)

@djhalliday
Copy link
Member Author

hmm, we should be able to refrain from having to maintain duplicate value xmls within each of the translated folders for things like colors.xml and styles.xml - and I've removed strings.xml from those other folders locally and it's still translating fine just using the one in values/. i'll push and you can take a crack at lining things up - but let me know what it takes?

also, have a look at k-9's translation. I like it a lot, the list is:
System default
Catala
Deutsch
etc.

I like the "system default" as default, and also like that each language is translated correctly. some stuff to chew on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants