Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Optional[dict] instead of dict for files parameter in transcribe.py #1258

Open
araman0 opened this issue Feb 27, 2025 · 1 comment
Open

Comments

@araman0
Copy link

araman0 commented Feb 27, 2025

In transcribe.py, the files parameter is currently defined as:

files: dict = None,

Since None is a valid default value, it would be more appropriate to use Optional[dict] to explicitly indicate that files can be None:

files: Optional[dict] = None,

This improves type clarity and aligns with Python's type hinting conventions.

Would you consider updating this for better type consistency?
I'm happy to submit a PR if needed.

@MahmoudAshraf97
Copy link
Collaborator

I'm open to typing revisions, you can open a PR which continues #1150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants