We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In transcribe.py, the files parameter is currently defined as:
transcribe.py
files
files: dict = None,
Since None is a valid default value, it would be more appropriate to use Optional[dict] to explicitly indicate that files can be None:
None
Optional[dict]
files: Optional[dict] = None,
This improves type clarity and aligns with Python's type hinting conventions.
Would you consider updating this for better type consistency? I'm happy to submit a PR if needed.
The text was updated successfully, but these errors were encountered:
I'm open to typing revisions, you can open a PR which continues #1150
Sorry, something went wrong.
No branches or pull requests
In
transcribe.py
, thefiles
parameter is currently defined as:Since
None
is a valid default value, it would be more appropriate to useOptional[dict]
to explicitly indicate thatfiles
can beNone
:This improves type clarity and aligns with Python's type hinting conventions.
Would you consider updating this for better type consistency?
I'm happy to submit a PR if needed.
The text was updated successfully, but these errors were encountered: