Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of timeout for test containers fails when timeout is reached #144

Open
greygoo opened this issue Mar 24, 2020 · 1 comment
Open

Comments

@greygoo
Copy link
Member

greygoo commented Mar 24, 2020

At

if [[ "${timeout}" == 0 ]]; then return 1; fi

we use return outside a function, which results in the error

./kubecf-test.sh: line 53: return: can only `return' from a function or sourced script when the timeout is reached for whatever reason.

This is also present in several other lines in the script that als use return outside a function

@viccuad
Copy link
Member

viccuad commented Apr 3, 2020

This may have been fixed with the refactor of #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants