Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targets should have only one responsibility #138

Open
jimmykarily opened this issue Mar 17, 2020 · 3 comments
Open

Targets should have only one responsibility #138

jimmykarily opened this issue Mar 17, 2020 · 3 comments

Comments

@jimmykarily
Copy link
Contributor

A target called "scf-deploy" should just deploy, not perform cleanup. There should be another target with the "cleanup" responsibility. We should even avoid having "batch" targets that group others targets if there is no good reason for that. "make deploy-k8s deploy-kubecf test-cats" reads better that "make all".
@jimmykarily
Copy link
Contributor Author

Here I'm proposing the opposite of this: #32

This one is also a bit relevant: #33

@viccuad
Copy link
Member

viccuad commented Mar 17, 2020

This marks this specific make scf-deploy as deprecated: #141

We could just remove it too, without deprecation.

@mudler
Copy link
Contributor

mudler commented Mar 18, 2020

We could just remove it too, without deprecation.

I oppose, deprecation should be part of the process!! 👮‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viccuad @mudler @jimmykarily