Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove scf from master #125

Open
prabalsharma opened this issue Mar 12, 2020 · 1 comment
Open

refactor: remove scf from master #125

prabalsharma opened this issue Mar 12, 2020 · 1 comment

Comments

@prabalsharma
Copy link
Member

It was discussed in recent QA and catapult meeting that everything which is relevant to scf should be in branch and master should only contain kubecf related code. This will simplify catapult to some extent and help us with feature enhancements.

@viccuad
Copy link
Member

viccuad commented Mar 13, 2020

I'm removing the priority critical label; it can wait until we are not breaking the pipelines, we have unit & integration test coverages and we are not endlessly backporting changes on the last 4 days (eg: #128).

If you feel it's priority critical, then I suggest you open a PR with the changes + unit & integration tests, links to personal versions/forks of runs of the ~12 pipelines that prove the changes don't break them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants