Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information contributor to items to moderate list screen #173

Open
laureD19 opened this issue Feb 20, 2024 · 4 comments · May be fixed by #174
Open

Add information contributor to items to moderate list screen #173

laureD19 opened this issue Feb 20, 2024 · 4 comments · May be fixed by #174
Labels
enhancement New feature or request

Comments

@laureD19
Copy link
Contributor

In the review mode, it would be good to see who is the contributor suggesting changes to an item. Especially, in the screen showing the list of items to moderate, information contributor could be added (the same way it is implemented in the history view of an item)

Currently on the items to moderate list:
image

How it looks like in the history list of items - with the information contributor visible in the list - example:
image

notify also @mkrzmr @KlausIllmayer @vronk
@laureD19 laureD19 added the enhancement New feature or request label Feb 20, 2024
@stefanprobst
Copy link
Contributor

stefanprobst commented Feb 20, 2024 •
edited
Loading

the "items-to-moderate" screen is using the item-search api endpoint, which currently returns the following shape (example):

{
  "id": 987654,
  "persistentId": "123456",
  "category": "tool-or-service",
  "label": "",
  "lastInfoUpdate": "Tue Feb 20 13:41:31 UTC 2024",
  "description": "",
  "contributors": [],
  "properties": [],
  "status": "suggested",
  "owner": "[email protected]"
}

we don't get the full information-contributor object, like we do from the item-history endpoint - we only get the owner field, which according to my notes is the same as informationContributor.username (while on the item-history screen we currently display informationContributor.displayName).

@stefanprobst
Copy link
Contributor

stefanprobst commented Feb 20, 2024 •
edited
Loading

example how it would look like (from the "stage" deployment)

Screenshot_20240220_150002

@stefanprobst
Copy link
Contributor

if we would rather display informationContributor.displayName, that would require changes to the api response.

@stefanprobst stefanprobst linked a pull request Feb 20, 2024 that will close this issue
Draft
@laureD19
Copy link
Contributor Author

laureD19 commented Jun 6, 2024 •
edited
Loading

depending on some backend implementation
additional field informationContributor.displayName in the item-search response

create a backend issue

@vronk vronk mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add information contributor metadata to moderate-items screen SSHOC/sshoc-marketplace-frontend
2 participants
@stefanprobst @laureD19